Jakub Narebski <jnareb@xxxxxxxxx> writes: > By the way, it is custom on this mailing list to usually Cc (send a > copy) to all people participating in discussion, and not only to git > mailing list. > > "W. Trevor King" <wking@xxxxxxxxxx> writes: > >> Subject: [PATCH v3] Isolate If-Modified-Since handling in gitweb > > Perhaps a better title would be: > > gitweb: Refactor If-Modified-Since handling, support in snapshot With "gitweb: " prefix to denote what area it affects, that is certainly better. Given the primary objective and effect is that the snapshot feature starts honoring i-m-s, gitweb: honor If-Modified-Since request header in snapshot would be sufficient. > to mention all that thispatch does. Though trouble with coming up > with a short but fairly complete one-line summary might mean that this > patch would be better split in two: refactoring and adding support for > If-Modified-Since to snapshots. If many existing callsites had duplicated code to handle i-m-s, we may want two patch series, the first of which consolidates them into a single helper function without changing anything else (most importantly, without regression) and the second that uses the helper to add support in the snapshot feature. But if that is not the case, I think we can go either way. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html