Jonathan Nieder wrote: > Dmitry Ivankov wrote: >> One more quick thought. "force the root mode to S_IFDIR" part doesn't >> look obviously good for me. First, isn't it already ensured that the >> root is a directory? [...] > It was just a problematic and incomplete version of what your "be > saner with temporary trees" does properly. To tie up this loose end: looks like David's patch was ok in this respect and my worries unfounded. What I was missing is that store_tree() does nothing unless its tree argument is dirty, and the temporary tree used to repesent <treeish> in "ls <treeish> <path>" is never dirty. Of course, the reminder of the "be saner" patch and the tree delta discussion was still very useful. Thanks for your thoughtfulness. Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html