Don't quite have the time to run tests, but maybe the issue is solved in a stalled series [1]. At least [1] is worth looking at with regard to this bug. One more quick thought. "force the root mode to S_IFDIR" part doesn't look obviously good for me. First, isn't it already ensured that the root is a directory? Second, if it is allowed to be a file I'm not sure it's ok to silently make it a directory on a root-to-subtree operation, do we do it for subtree-to-subsubtree? P.S. looking at [1] now I'd say the commit messages could be improved there [1] http://thread.gmane.org/gmane.comp.version-control.git/179426 On Thu, Mar 8, 2012 at 10:39 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > >> For what it's worth, >> Acked-by: Jonathan Nieder <jrnieder@xxxxxxxxx> >> >> Thanks very much for taking care of it. >> >>> [Subject: fast-import: fix ls command with empty path] >> >> I would s/fix/accept/ to be more precise about the nature of the >> breakage. (In other words: rather than mishandling ls with an empty >> path, fast-import was not handling it at all.) >> >> ... >> (good). What do you think? >> >> -- >8 -- >> Subject: fast-import: allow filecopy to copy from root > > So what do you guys want to do with topic? My gut feeling is that > this is not a new regression and can wait until the next cycle. I > could certainly carry David's patch in 'pu' if doing so helps the > discussion to come up with the right solution, though. > > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html