René Scharfe <rene.scharfe@xxxxxxxxxxxxxx> writes: > Am 07.03.2012 22:59, schrieb Junio C Hamano: >> René Scharfe<rene.scharfe@xxxxxxxxxxxxxx> writes: >> >>> Am 05.03.2012 22:34, schrieb Junio C Hamano: >>> >>>> +#define util_as_int(elem) ((intptr_t)((elem)->util)) >>> >>> Something that actually returns an int would fit the name better. ;) >> >> The particular type would not matter to the callers of the helper >> macro, would it? > > Three of the five callers introduced in that commit cast the result to > int and the remaining two don't care, so it actually does seem to > matter for most of them, strictly speaking. When I see a nit, I can't > resist the urge to pick it, apparently. Unfortunately, replacing intptr_t with int or casting the above again as int will result in builtin/fmt-merge-msg.c: In function 'record_person': builtin/fmt-merge-msg.c:213: error: cast to pointer from integer of different size So... -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html