René Scharfe <rene.scharfe@xxxxxxxxxxxxxx> writes:
> Am 05.03.2012 22:34, schrieb Junio C Hamano:
>
>> +#define util_as_int(elem) ((intptr_t)((elem)->util))
>
> Something that actually returns an int would fit the name better. ;)
The particular type would not matter to the callers of the helper
macro, would it?
>> +static int committer_is_me(const char *name)
>> +{
>> + int namelen = strlen(name);
>> + const char *me = git_committer_info(IDENT_NO_DATE);
>> + return (me && !memcmp(me, name, namelen) &&
>> + !memcmp(me + namelen, " <", 2));
>> +}
>
> This looks scary due to the missing length check of me before the
> memcmp() call, but is actually safe because git_committer_info()
> returns a pointer to a static buffer that is just as long as name can
> possibly be. Still, perhaps this is nicer instead:
>
> const char *me = git_committer_info(IDENT_NO_DATE);
> const char *rest = skip_prefix(me, name);
> return rest && skip_prefix(rest, " <");
Probably. Let me fix it up.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html