Re: [PATCH 1/2] perf: compare diff algorithms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Narebski <jnareb@xxxxxxxxx> writes:

> Beside extracting logic that sets GITPERLLIB into separate file like
> in Junio proposal?

That was not even a proposal.  The part that deals with valgrind is
blatantly wrong (it shouldn't create symlinks in that code, it only
should figure out where things should be).

> You can always assume that it is fixed relative
> to perl/Git.pm, and use __DIR__ or $FindBin to make "use lib", e.g.
>
>   use FindBin;
>   use lib "$FindBin::Bin/../../perl";

Use of FindBin to find the location of the script is OK, but does
using "../../perl" really work?

We have this

  GITPERLLIB="$GIT_BUILD_DIR"/perl/blib/lib:"$GIT_BUILD_DIR"/perl/blib/arch/auto/Git

to look for two places in test-lib.sh
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]