Re: [PATCH 1/2] perf: compare diff algorithms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Narebski <jnareb@xxxxxxxxx> writes:

> Junio C Hamano <gitster@xxxxxxxxx> writes:
>> 
>> But of course, this from a command line would not work:
>> 
>> 	$ perl -MGit
>> 
>> I do not expect it to, and for the ease of testing new versions, I
>> prefer it not to work.
>> 
>> In any case, you should be able to do anything under t/ _before_
>> installing, so relying on having Git.pm in normal @INC is a double
>> no-no.
>
> Thomas, take a look at how it is solved in 't/t9700/test.pl', used by
> 't/t9700-perl-git.sh':
>
>   use lib (split(/:/, $ENV{GITPERLLIB}));

Hum.  The problem is that the user may invoke aggregate.perl manually,
and GITPERLLIB won't be set in that case.

Is there a better solution than duplicating the logic that sets
GITPERLLIB in test-lib.sh within aggregate.perl?

-- 
Thomas Rast
trast@{inf,student}.ethz.ch
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]