Re: [PATCH 2/2] Support Out-Of-Tree Valgrind Tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



greened@xxxxxxxxxxxxx (David A. Greene) writes:

>> Don't we, right now, get stuff as follows:
>>
>>   item                   path
>>   --------------------------------------------
>>   test-lib.sh            $TEST_DIRECTORY
>
> Right now, yes, but it breaks for out-of-tree tests.  In the out-of-tree
> case, TEST_DIRECTORY doesn't contain test-lib.sh.  For exmaple, in

Could it be that the reason for the breakage is because you are
setting TEST_DIRECTORY to the directory that contains out-of-tree
tests, instead of $GIT_BUILD_DIR/t/ directory?

The place you perform your operations are relative to $TRASH_DIRECTORY,
and you would still find the main git relative to $GIT_BUILD_DIR.

Shouldn't TEST_DIRECTORY merely a short-hand for GIT_BUILD_DIR/t?
What do you find relative to $TEST_DIRECTORY that cannot be found
relative to GIT_BUILD_DIR/t?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]