Thomas Rast <trast@xxxxxxxxxxx> writes: > Don't we, right now, get stuff as follows: > > item path > -------------------------------------------- > test-lib.sh $TEST_DIRECTORY > git $GIT_BUILD_DIR/bin-wrappers > valgrind.sh $TEST_DIRECTORY/valgrind > git (with --valgrind) $TEST_DIRECTORY/valgrind/bin > > You are saying this must change to an entirely new path > > valgrind.sh $GIT_VALGRIND_TOOLS > git (with --valgrind) $GIT_VALGRIND_TOOLS/bin > > but what's wrong with simply > > valgrind.sh $GIT_BUILD_DIR/t/valgrind > git (with --valgrind) $TEST_DIRECTORY/valgrind/bin > > In the common case of t/, these just map to what we had before. In the > out-of-tree case, we'd create valgrind/bin in the test directory for the > *temporary* stuff, and still look for the wrapping valgrind.sh in the > git tree. Sounds sane. Simple is good. No matter what happens to this particular patch, could we have the above table (the final version of it, that is) in t/README or something, please? Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html