On 03/06/2012 03:33 PM, Elia Pinto wrote: > Introduce a new --with-gcc-warnings configure option > using a new autoconf macro that check if the compiler > know the option passed or not in a portable way, as > it not depends from the gcc version or from the > other compiler used. > > Signed-off-by: Elia Pinto <gitter.spiros@xxxxxxxxx> > --- > This is the version 2 of the patch, in which i have > slightly changed the commit message for > clarify the purpose. To activate the > patch is of course necessary to do a autoreconf -vfi after > applying the patch. > > > Makefile | 2 +- > config.mak.in | 1 + > configure.ac | 118 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 120 insertions(+), 1 deletions(-) > > diff --git a/Makefile b/Makefile > index be1957a..d0aef0f 100644 > --- a/Makefile > +++ b/Makefile > @@ -310,7 +310,7 @@ endif > > CFLAGS = -g -O2 -Wall > LDFLAGS = > -ALL_CFLAGS = $(CPPFLAGS) $(CFLAGS) > +ALL_CFLAGS = $(CPPFLAGS) $(CFLAGS) $(AM_CFLAGS) > Wouldn't it be better to use $(WARN_CFLAGS) here? It makes the purpose of the variable clearer, and don't give the wrong impression that Automake is involved (as the 'AM_' prefix might suggest). > ALL_LDFLAGS = $(LDFLAGS) > STRIP ?= strip > > diff --git a/config.mak.in b/config.mak.in > index b2ba710..5b7dbfd 100644 > --- a/config.mak.in > +++ b/config.mak.in > @@ -2,6 +2,7 @@ > # @configure_input@ > > CC = @CC@ > +AM_CFLAGS = @GIT_CFLAGS@ > Accordingly here: s/AM_CFLAGS/WARN_CFLAGS/ and s/GIT_CFLAGS/WARN_CFLAGS/. > +# GIT_CFLAGS_ADD(PARAMETER, [VARIABLE = GIT_CFLAGS]) > +# ------------------------------------------------ > And here as well: s/GIT_CFLAGS/WARN_CFLAGS/. Ditto for the rest of the M4 file. Regards, Stefano -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html