On Fri, Feb 24, 2012 at 12:03:17PM -0800, Junio C Hamano wrote: > > - else if (size <= big_file_threshold || type != OBJ_BLOB) > > + else if (size <= big_file_threshold || type != OBJ_BLOB || > > + convert_to_git(path, NULL, 0, NULL, 0)) > > Nice. It would be even nicer to give a readability macro whose name makes > it clear that this is a query (unfortunately we cannot add '?' at the end > of the function name) and not a conversion. Any name suggestions? Yeah, I cringed a little at all of the NULLs. How about: int would_convert_to_git(const char *path); ? > By the way, I tried this with the tip of 'pu' as of last night, and the > result segfaults on me in t1050 (hash-object -w) ;-). Eek. I ran through "make test" on my finished series without a problem, but it may be a bad interaction with something in "pu", or maybe a heisenbug. I'll investigate. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html