On 19.02.2012 09:44, Junio C Hamano wrote:
If we cherry pick your commit somewhere else with "-x -s", the resulting
commit log message would end like this:
Aside from that, even with a non-trivial commit the generated note
"(cherry picked from commit 555c9864971744abb558796aea28e12a1ac20839)"
seems abrupt when appended directly.
Cc: Eric Raible<raible@xxxxxxxxxxx>
Signed-off-by: Beat Bolli<bbolli@xxxxxxxxx>
(cherry picked from commit 555c9864971744abb558796aea28e12a1ac20839)
Signed-off-by: Frotz Xyzzy<nitfol@xxxxxxxxxx>
which clearly is worse-looking with the extra LF you added in this patch.
Clearly? I would not say so, on the contrary. When using -s together
with -x, I'd interpret this as signing off the process of cherry-picking
itself, and as such, visually grouping the additional "signed-off" with
the "cherry picked from" makes sense to me.
--
Sebastian Schuberth
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html