On 02/21/2012 12:41 AM, Junio C Hamano wrote:
Zbigniew Jędrzejewski-Szmek<zbyszek@xxxxxxxxx> writes:
JC:
Perhaps the maximum for garph_width should be raised to something like
"min(80, stat_width) - name_width"?
I think that a graph like
a | 1000 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
b | 1 -
is not very readable. I like the consistency forced by the 40-column limit.
But I guess that this is very subjective.
The above makes it very obvious that there is a huge amount of change made
to 'a' and a bit of deletion to 'b', compared to a mini-graph that is
truncated to half the screen width.
Yes. But the same graph with 40 columns tells me exactly the same thing.
OTOH, if the filenames+graph fill the whole 80 columns, everything is
nicely aligned wrt. to text above and below. Maybe it should be
configurable after all?
Besides, the above is what you would get without your patch on 80-column
terminal, no?
Yes.
Zbyszek
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html