Johannes Sixt <j.sixt@xxxxxxxxxxxxx> writes:
> Am 2/17/2012 2:19, schrieb jehan@xxxxxxx:
>> @@ -747,13 +753,19 @@ int convert_to_git(const char *path, const char *src, size_t len,
> ...
>> ret |= apply_filter(path, src, len, dst, filter);
>> + if (!ret && required)
>> + die("required filter '%s' failed", ca.drv->name);
>
> Wouldn't it be much more helpful if this were:
>
> die("%s: clean filter '%s' failed", path, ca.drv->name);
>
> Likewise (with s/clean/smudge/) in convert_to_working_tree_internal().
>
>> + ! git checkout -- test.fs
>
> test_must_fail git checkout -- test.fs
>
>> + ! git add test.fc
>
> test_must_fail git add test.fc
>
> -- Hannes
Thanks; I'll just squash these in in-place.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html