Re: [PATCH v2] Add a setting to require a filter to be successful

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 2/17/2012 2:19, schrieb jehan@xxxxxxx:
> @@ -747,13 +753,19 @@ int convert_to_git(const char *path, const char *src, size_t len,
...
>  	ret |= apply_filter(path, src, len, dst, filter);
> +	if (!ret && required)
> +		die("required filter '%s' failed", ca.drv->name);

Wouldn't it be much more helpful if this were:

	die("%s: clean filter '%s' failed", path, ca.drv->name);

Likewise (with s/clean/smudge/) in convert_to_working_tree_internal().

> +	! git checkout -- test.fs

	test_must_fail git checkout -- test.fs

> +	! git add test.fc

	test_must_fail git add test.fc

-- Hannes
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]