Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> writes: > On 02/15/2012 06:12 PM, Junio C Hamano wrote: >> Zbigniew Jędrzejewski-Szmek<zbyszek@xxxxxxxxx> writes: >> >>> Eleven tests for various combinations of a long filename and/or big >>> change count and ways to specify widths for diff --stat. >>> --- >> >> Sign-off? > >> Hrm, this does not seem to pass, making the result of applying [1/3] fail; >> I see that the elided name is shown much shorter than the above expects. > > Hi, > > I'm sorry for not properly testing the patch with tests. I somehow > convinced myself that the tests pass. This whole series needs more > work, even after squashing in your two patches. It is nothing to be sorry about if a series needs more polishing; that is what the review discussions are for. I've queued the series after restructuring it, and merged except for [3/3] to 'pu', which conflicts too heavily with the nd/diffstat-gramnum topic that is already in 'master'. I'd say we should concentrate on your first two patches without the "num-width" stuff and get them in first, and then later consider if rerolling the [3/3] patch is worth it after the dust settles. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html