On Thu, Feb 16, 2012 at 12:39 AM, Matthieu Moy <Matthieu.Moy@xxxxxxx> wrote: > + > +verbose () { > + if [ "$verbose" = 1 ]; then > + printf "%s ..." "$@" > + fi > +} In addition to preferring "test" over "[", we also prefer to write these on several lines. It's probably time to update the CodingStyle document with these notes. e.g. if test "$verbose" = 1 then .... do stuff fi (with hard-tabs, not spaces (unlike my example)) -- David -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html