Michal Kiedrowicz <michal.kiedrowicz@xxxxxxxxx> writes: > I just started to wonder if we couldn't use output from Jeff's > diff-highlight for gitweb. That could be a sensible approach, but > We could tech diff-highlight to produce diffs > marked with -{} and +{} (this is the notation used by Jeff in one of his > recent patches) or something like this and then just convert that into > HTML markup. this implementation strategy would not work well, given that the payload can contain arbitrary letter sequence (e.g. a Perl script that wants be explicit when writing a hashref literal write +{...} to disambiguate it from a block). If you are going to modularize diff-highlight and reuse it, it needs to learn how to talk HTML to properly escape the payload. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html