Jakub Narebski <jnareb@xxxxxxxxx> wrote: > Michał Kiedrowicz <michal.kiedrowicz@xxxxxxxxx> writes: > > > The code that comares lines is based on > > contrib/diff-highlight/diff-highlight, except that it works with > > multiline changes too. It also won't highlight lines that are > > completely different because that would only make the output > > unreadable. Combined diffs are not supported but a following commit > > will change it. > > I was thinking that if gitweb were to support "diff refinement > highlighting", it would either use one of *Diff* packages from CPAN, > or "git diff --word-diff" output. > I just started to wonder if we couldn't use output from Jeff's diff-highlight for gitweb. We could tech diff-highlight to produce diffs marked with -{} and +{} (this is the notation used by Jeff in one of his recent patches) or something like this and then just convert that into HTML markup. Changes in gitweb would be minimal, we would reduce redundancy and could focus on improving matching algorithm in one place. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html