Jeff King <peff@xxxxxxxx> writes: >> If everything_local() is trying to check that the references are in the >> local repository plus alternates, then it is incorrect that >> everything_local() doesn't consider alternate references in its >> determination. My guess is that this is the case, and that something >> like the following might be the fix: > > Junio could answer more authoritatively than I, but I am pretty sure it > is the latter. The point is to skip the expensive find_common > negotiation if we know that there are no objects to fetch. Thus the > "local" here is "do we have them on this side of the git-protocol > connection", not "do we have them in our non-alternates repository". Correct. The function is about "do we need to get any object from the other side?" optimization. I originally thought to go through the rest of your message, but I realized I can just say "everything you said is correct and I have nothing more to add." Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html