On Mon, Feb 06, 2012 at 12:36:05AM -0800, Junio C Hamano wrote: > > For that matter, shouldn't we make sure that the type is OBJ_TAG? It might > > make sense to allow OBJ_COMMIT (i.e. lightweight tag to a commit) as well, > > because the definition of "first N lines" is compatible between tag and > > commit for the purpose of the -n option. > > Ahh, Ok, your 3/3 addresses this exact issue. > > I do not object to silently return when the object is not OBJ_TAG (even > though I slightly prefer showing the first N lines of commit log contents > for OBJ_COMMIT lightweight tag), but I still think it should be warned > just like a corruption when we see (type == OBJ_TAG && !size). OK, that's easy enough to do. Should we show lightweight tags to commits for backwards compatibility (and just drop the parse_signature junk in that case)? The showing of blobs or trees is the really bad thing, I think. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html