Hi, On Sat, 9 Dec 2006, Jeff King wrote: > On Sun, Dec 10, 2006 at 12:21:03AM +0100, Johannes Schindelin wrote: > > > > Instead, remove at most one space between name and address. > > > > Why? We can fix it properly: Instead of > > > > > - while (isspace(bob[-1])) > > > + if (isspace(bob[-1])) > > > > do something like > > > > while (bob - 1 != buffer + 7 && > > isspace(bob[-1])) > > It doesn't look like there are ever extra spaces to get soaked up in the > kernel or git repositories, but if there is a reason to expect > Full Name <user@domain> > then we should probably replace my fix with yours. This is exactly the kind of assumption which led to the bug to begin with. Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html