Jeff King <peff@xxxxxxxx> writes: > It doesn't look like there are ever extra spaces to get soaked up in the > kernel or git repositories, but if there is a reason to expect > Full Name <user@domain> > then we should probably replace my fix with yours. As far as I know, commit-tree removes the extra space if exists, so your fix would be fine in practice. People could write crappy replacements of plumbing, and we may end up with names with trailing whitespaces, but with your fix at least that would not make us crash, and it may even be considered a feature -- it would serve as a coalmine canary to detect such a broken alternative program that creates bogus commit objects. We might want to tighten fsck-objects to warn about them, though. But that is probably rather low priority. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html