Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > In any case, there's no need for ad hominem arguments; there is a > problem when using zsh, that's a fact. There was no ad-hominem argument at all. Read your two lines I quoted "... the code is now actually understandable (at least to me), while before it looked like voodoo", which was your words. What does it tell the reader? The patch author (1) did not understand existing code (voodoo) and (2) the change is a good thing as a style/readability improvement. I was saying that I did not want to see that in the justification, because (2) is not true, while (1) may be. The patch as-is is a good change that works around issues with zsh's POSIX emulation, and that is sufficient-enough justification. IOW, we are in agreement on the later half of your sentence. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html