Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > Let's avoid it. This has the advantage that the code is now actually > understandable (at least to me), while before it looked like voodoo. I am somewhat hesitant to accept a patch to shell scripts on the basis that the patch author does not understand the existing constructs that are standard parts of shell idioms. Avoiding zsh's bug that cannot use conditional assignment on the no-op colon command (if the bug is really that; it is somewhat hard to imagine if the bug exists only for colon command, though) *is* by itself a good justification for this change, even though the resulting code is harder to read for people who are used to read shell scripts. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html