Junio C Hamano wrote: > Jonathan Nieder <jrnieder@xxxxxxxxx> writes: >> Nice implementation. I still don't understand why NO_GETTEXT=YesPlease >> should not imply this. > > Should be easy to do so, like this? > > diff --git a/Makefile b/Makefile > index a782409..c4c1066 100644 > --- a/Makefile > +++ b/Makefile > @@ -1521,6 +1521,7 @@ ifdef GETTEXT_POISON > endif > ifdef NO_GETTEXT > BASIC_CFLAGS += -DNO_GETTEXT > + USE_GETTEXT_SCHEME = fallthrough > endif Yep, that would make my worries about intuitive behavior evaporate. :) (Maybe "USE_GETTEXT_SCHEME ?= fallthrough" to make it easier to override in config.mak.) Thanks. I also would not actually mind the behavior without that tweak, as long as it's explained somewhere. Ciao, Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html