On 21/01/12 04:54, Junio C Hamano wrote:
Vitor Antunes<vitor.hda@xxxxxxxxx> writes:
+ grep -q update file2&&
Do you really need to use "-q" here? Wouldn't it help if you wrote it
without it while debugging tests with "sh ./t9801-*.sh -v"?
Also how does this series interact with the series Luke posted earlier on
branches and labels?
Vitor's series applies cleanly to my changes.
However, one thing I noticed in reading through is that it will break if
you end up importing a P4 branch that has spaces (or other shell chars)
in its name. A quick test confirms this.
- the code doesn't handle the names properly
- git and p4 have different ideas about valid branch names
But before rejecting Vitor's changes because of that it would be worth
considering whether we care (much). My own opinion is that if you have
developers who are daft enough to put spaces or dollars in their branch
names then their project is already doomed anyway....
Perhaps it would be enough just to issue a warning ("your project is
doomed; start working on your CV") and skip such branch names rather
than falling over with inexplicable error messages.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html