Junio C Hamano <gitster@xxxxxxxxx> writes:
> Thomas Rast <trast@xxxxxxxxxxxxxxx> writes:
>
>> @@ -571,8 +574,8 @@ then
>> else
>> utf8=-n
>> fi
>> -if test "$(cat "$dotest/keep")" = t
>> -then
>> +keep=$(cat "$dotest/keep")
>> +if test "$keep" = t
>> keep=-k
>> fi
>
> Curious.
>
> Who writes 't' to $dotest/keep after this patch is applied?
Nobody; like the commit message says, I was just trying to help users
upgrading from one version to the next in the middle of an 'am', which
almost worked except for
> I suspect that this patch was not tested in a way to exercise this
> codepath; shell would have barfed when seeing the lack of "then" here, no?
(ouch)
> I also do not want to worry about "echo" portability issues that may come
> from an existing
>
> echo "$keep" >"$dotest/keep"
>
> that this patch does not touch.
Good point, thanks. I'll reroll with printf. Should I keep the
upgrade path compatibility?
--
Thomas Rast
trast@{inf,student}.ethz.ch
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html