Thomas Rast <trast@xxxxxxxxxxxxxxx> writes: > @@ -571,8 +574,8 @@ then > else > utf8=-n > fi > -if test "$(cat "$dotest/keep")" = t > -then > +keep=$(cat "$dotest/keep") > +if test "$keep" = t > keep=-k > fi Curious. Who writes 't' to $dotest/keep after this patch is applied? I also do not want to worry about "echo" portability issues that may come from an existing echo "$keep" >"$dotest/keep" that this patch does not touch. I suspect that this patch was not tested in a way to exercise this codepath; shell would have barfed when seeing the lack of "then" here, no? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html