On Sat, Jan 07, 2012 at 12:54:36PM +0100, Clemens Buchacher wrote: > Error out if we just spawned the daemon and yet we cannot connect. Actually it was intentional not to produce an error. The cache helper is just a cache, so I consider it "best effort", and if it cannot cache a password, it's not the end of the world. Git should continue, anyway. That being said, it's probably nicer to be informative in this case than not, since it is a configuration error the user probably would like to fix. And since the rewrite of the credential helper API, it's OK for helpers to return a failing exit code; git will just ignore it and keep going. So I think this is a reasonable thing to do. Acked-by: Jeff King <peff@xxxxxxxx> > And always release the string buffer. Oops, thanks. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html