On Fri, Jan 06, 2012 at 08:48:00PM +0100, Clemens Buchacher wrote: > I have rebased Junio's cb/git-daemon-tests onto your > jk/child-cleanup and replaced the call to pkill with a regular kill > command. Looks pretty good from my cursory examination. I think you should fill out the rationale for "kill dashed externals on exit" a bit. My reasoning is that whether a git command is an internal or external process is purely an implementation detail, and killing the git wrapper should behave identically in both cases. > On top of that, I have added two commits to fix the discussed race > condition. I also verified that the race condition actually happens > by adding an artificial delay in the daemon (this change is > obviously not included). Looks reasonable to me. > I pushed the new cb/git-daemon-tests to > https://github.com/drizzd/git . If you have no objections I will > post the entire series including your run-command and send-pack > patches to the list. No objections here. Thanks for moving this forward. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html