Clemens Buchacher <drizzd@xxxxxx> writes: > Are you saying that the name "daemon" is too general, and it should > instead be "lib-git-daemon.sh" and GIT_TEST_GIT_DAEMON? Or do you > mean that it is not general enough and it should be called > lib-networking.sh and "GIT_TEST_NETWORKING"? The former. "daemon" is too general and letting "git daemon" squat on that name makes it harder for other people to build daemons for new git services and write tests for them. > Either way, I have no preference here. Feel free to change any way you > like. No thanks. >> >> + # kill git-daemon child of git >> >> + say >&3 "Stopping git daemon ..." >> >> + pkill -P "$DAEMON_PID" >> >> How portable is this one (I usually do not trust use of pkill anywhere)? > > I read that it is supposed to be more portable than skill or killall. > But I have no way to research this. I have implemented a workaround > using only 'ps' and 'kill' in [PATCH 3/6] avoid use of pkill. Yuck, that patch looks even uglier X-<. Do you really need to kill the children but not the daemon? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html