Am 28.12.2011 23:29 schrieb Junio C Hamano: >>> I suspect that we would need to enhance *_ASKPASS interface first, so that >>> we can ask things other than passwords. Until that happens, I do not think >>> we should apply the second patch to use *_ASKPASS for non-passwords. >> >> git-core also asks for username using *_ASKPASS, this is the reason why >> I implemented it this way. I noticed it when I tried to push to google >> code (using https). > > I thought that was updated with Peff's series recently? So, was this changed? git-core doesn't ask for a username using *_ASKPASS helpers anymore? > In any case, your username has a lot minor annoyance factor if we force > you to type in blind, but the second patch in your series ask things other > than that using the same mechanism, so it is not a good excuse for this > usability regression in git-svn, I would think. Yeah, typing a whole path is more annoying. But not being able to clone (push, ...) w/o being able to type in a username or accept an unknown certificate is also problematic. I talked off-list with Junio and he proposed to use another environment variable (e.g. GIT_DIALOG for a different tool) to solve these issues. A good way could be to define the GIT_DIALOG-tools to have two parameters. First (pass|text|filename|...) with fallback to text, this way one can implement a password field, a text field, a file chooser (on type filename) and it is still extendable for e.g. directory choosers (if we might need that)... To make it even more complicated one could also say that we propose more parameters (e.g. two additional parameters for working copy directory and repository), so that answers can be stored by the dialog-helper in the .git-directory. -- Best regards, Sven Strickroth ClamAV, a GPL anti-virus toolkit http://www.clamav.net PGP key id F5A9D4C4 @ any key-server -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html