Am 28.12.2011 22:38 schrieb Junio C Hamano: > I am however not sure if the second patch in this series is a good thing > in the current shape. For GUI users who do not have a terminal, earlier > they couldn't respond to these questions but now they can, so in that > narrow sense we are not going backwards. > > But for people who use *_ASKPASS and are working from the terminal, it is > a regression to ask these non-password questions using *_ASKPASS. Most > likely, these helpers that are designed for password entry will hide what > is typed, and I also wouldn't be surprised if some of them have fairly low > input-length restriction that may be shorter than a long-ish pathname that > users might want to give as an answer, which they could do in the terminal > based interaction but will become impossible with this patch. > > I suspect that we would need to enhance *_ASKPASS interface first, so that > we can ask things other than passwords. Until that happens, I do not think > we should apply the second patch to use *_ASKPASS for non-passwords. git-core also asks for username using *_ASKPASS, this is the reason why I implemented it this way. I noticed it when I tried to push to google code (using https). -- Best regards, Sven Strickroth ClamAV, a GPL anti-virus toolkit http://www.clamav.net PGP key id F5A9D4C4 @ any key-server -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html