Vijay Lakshminarayanan <laksvij@xxxxxxxxx> writes: > The code reads fine when there's no numeral 1 around but now it doesn't > read well. I think refactoring > > struct commit_list *l > > to > > struct commit_list *lst > > is justified. Thoughts? Not justified at all. What is "lst" and why is it not spelled "list"? It is a disease to drop vowels when you do not have to. If I were to name a new variable that points at one element of a linked list and is used to walk the list (surprise!) "element" or perhaps "elem" for short, but in the context of that short function I honestly do not see much need for such a naming. The variable is extremely short-lived and there is no room for confusion. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html