On Tue, Dec 13, 2011 at 07:37:22AM +0530, Vijay Lakshminarayanan wrote:
> > diff --git a/builtin/blame.c b/builtin/blame.c
> > index 80febbe..c19a8cd 100644
> > --- a/builtin/blame.c
> > +++ b/builtin/blame.c
> > @@ -1191,6 +1191,8 @@ static int num_scapegoats(struct rev_info *revs, struct commit *commit)
> > {
> > int cnt;
> > struct commit_list *l = first_scapegoat(revs, commit);
> > + if (revs->first_parent_only)
> > + return l ? 1 : 0;
> > for (cnt = 0; l; l = l->next)
> > cnt++;
> > return cnt;
>
> I just spent 30s staring at this wondering why you needed to do
>
> return 1 ? 1 : 0;
>
> which always returns 1 anyway before I realized it was a lowercase L.
>
> The code reads fine when there's no numeral 1 around but now it doesn't
> read well. I think refactoring
>
> struct commit_list *l
>
> to
>
> struct commit_list *lst
>
> is justified. Thoughts?
Sure, that would help. I wasn't planning to push this forward as a
"real" patch, but if somebody wants to do some testing and, more
importantly read through the code to make sure I am not violating some
assumptions, then it might be worth including upstream.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html