Hi again, Jonathan Nieder wrote: > Ramkumar Ramachandra wrote: > [...] > > So, is it a bad test? I'll just drop this test. >> Way starts with creating an API for "git commit". > > Not sure what this means. It certainly doesn't make any sense when you quote it like that. What I meant is that: by convention, 'git cherry-pick' is supposed to exit with positive status on conflict. Conversely, this means that a positive exit status can be interpreted as a conflict, but this is clearly not the case here. How do we fix this problem? By creating an API for "git commit", not by shelling out like this and letting it take over the exit status. -- Ram -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html