Ramkumar Ramachandra wrote: > format_todo() calls get_message(), but uses only the subject line of > the commit message. As a minor optimization, save work and > unnecessary memory allocations by using find_commit_subject() instead. Nice. Thanks for explaining. > Also, remove the unnecessary check on cur->item: the previous patch > makes sure that instruction sheets with missing commit subjects are > parsable. I guess you mean the check that cur->item->buffer is non-NULL. But now I am confused --- what would that have to do with instruction sheets with missing commit subjects? If cur->item->buffer is NULL, isn't find_commit_subject going to segfault regardless? Can cur->item->buffer be NULL? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html