Hi, Jonathan Nieder wrote: > It would be easier to read if each preimage test assertion were next to > the corresponding postimage test assertion. Does "git diff --patience" > do better? No, unfortunately. > If cleaning up the style anyway, I would write this as > [...] > But leaving it alone like you did is probably better. ;-) Exercising restraint. Otherwise, I'm tempted to fix every little nit in every test I'm touching in the series :P >> -test_expect_success 'check if fsck ignores the subprojects' \ >> - 'git fsck --full' >> +test_expect_success 'check if fsck ignores the subprojects' ' >> + git fsck --full >> +' > > Does this test imply that one of the subprojects is broken somehow? Hm, you're right- the test doesn't seem to make any sense. I'll deal with it in another patch (unrelated to this series). Thanks. -- Ram -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html