Ramkumar Ramachandra wrote: > Use test_cmp in preference to repeatedly comparing command outputs by > hand. > > Signed-off-by: Ramkumar Ramachandra <artagnon@xxxxxxxxx> > --- > t/t1006-cat-file.sh | 53 +++++++++++--------------------------------------- > 1 files changed, 12 insertions(+), 41 deletions(-) I guess test_cmp didn't exist yet when this code was written, though that doesn't explain why "diff" or "cmp" was not used. Doesn't this miss some other instances of the test $expect = $actual idiom in the same test script? What distinguishes the cases that you fixed from the ones skipped, and is it worth an inconsistent style to convert some without the others? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html