Hi Jonathan, Jonathan Nieder wrote: > Ramkumar Ramachandra wrote: >> Junio C Hamano wrote: > >>> Or perhaps http://thread.gmane.org/gmane.comp.version-control.git/184963/focus=185436 >> >> I noticed that sha1_to_hex() also operates like this. The >> resolve_ref() function is really important, but using the same >> technique for these tiny functions is probably an overkill > > I don't follow. Do you mean that not being confusing is overkill, > because the function is small that no one will bother to look up the > right semantics? Wait, that sentence didn't come out the way I > wanted. ;-) I meant overkill in terms of the work required and code churn. Ofcourse, I'd have been more than happy to see it being implemented- and you've actually done it now! :) Nguyễn has a more fancy solution, though I'm quite happy with this as it is. Finally, for all the times I've fumbled in git_path() usage: Liked-by: Ramkumar Ramachandra <artagnon@xxxxxxxxx> Thanks for working on this. -- Ram -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html