On Tue, Nov 15, 2011 at 02:49:58PM -0500, Jeff King wrote: > The existing prepare_argv uses a fixed-size static buffer to > hold all of the arguments, and then puts pointers into the > buffer into a fixed-size array. Using argv_array gets rid of > all of the manual bookkeeping and makes the code more > readable. > > It also lifts the static limits on the size of the array. > This is convenient, but is perhaps a security regression, as > a malicious client can now ask us to create arbitrary-length > argv arrays in memory. > > Signed-off-by: Jeff King <peff@xxxxxxxx> Sorry, I failed to mark the subject properly. If it was not obvious, this is patch 2/2 of the cleanup. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html