Erik Faye-Lund wrote: > The POSIX-function fork is not supported on Windows. Use our > start_command API instead. > > As this is the last call-site that depends on the fork-stub in > compat/mingw.h, remove that as well. > > Add an undocumented flag to git-archive that tells it that the > action originated from a remote, so features can be disabled. > Thanks to Jeff King for work on this part. > > Remove the NOT_MINGW-prereq for t5000, as git-archive --remote > now works. I see valgrind failures bisecting to this commit, like so: ==19125== Syscall param execve(argv[i]) points to unaddressable byte(s) ==19125== at 0x5303CB7: execve (in /lib64/libc-2.11.3.so) ==19125== by 0x53045A5: execvpe (in /lib64/libc-2.11.3.so) ==19125== by 0x4B183C: execv_git_cmd (exec_cmd.c:137) ==19125== by 0x4F305E: start_command (run-command.c:277) ==19125== by 0x47F5C9: cmd_upload_archive (upload-archive.c:98) ==19125== by 0x4051F4: run_builtin (git.c:308) ==19125== by 0x40538F: handle_internal_command (git.c:466) ==19125== by 0x405556: main (git.c:553) ==19125== Address 0x7feffe7d0 is not stack'd, malloc'd or (recently) free'd when running 'make valgrind' in current master. Let me know if you need more information. -- Thomas Rast trast@{inf,student}.ethz.ch -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html