Junio C Hamano wrote: > With the removal of the check, you _have_ to rely on static analyzers to > do the _right thing_, but if you have static analyzers that do the right > thing, you do not have to have such a workaround to begin with. No, automatic static analyzers will not help you avoid using an uninitialized enum value here (well, I guess they could, but I don't believe gcc or clang is nearly smart enough for that). The only replacement for the check is (1) humans and (2) valgrind. In this particular case, as you mentioned before, (1) seems to be quite sufficient. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html