Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > So, the purpose of this patch was to work around this common bug in > static analyzers. I fail to see how it could be even considered a work around. If you do not use static analyzers, you do not have to do such a change, and the resulting code would (not the "negative" side, but the "positive" side) catch real bugs when somebody screwes up and stuffs a bogus oob value in p->field. With the removal of the check, you _have_ to rely on static analyzers to do the _right thing_, but if you have static analyzers that do the right thing, you do not have to have such a workaround to begin with. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html