Kato Kazuyoshi <kato.kazuyoshi@xxxxxxxxx> writes:
> Probably like:
>
> - format_diff_line returns a class with an line.
> - remove trailing space from the class.
> - add side-by-side feature and CSS.
> - add form.
>
> Thank you for your correction!
My wording came out a bit too strong; I didn't mean to "correct" anything.
I think a better organization would be
[1/2] change code so that $diff_class does not have leading SP
optionally catch a case where $diff_class stays empty as an error?
[2/2] add side-by-side feature, which would involve:
- making format_diff_line() to return $diff_class separately;
- necessary addition of CSS;
- addition of form to trigger the feature.
I do not think splitting the second patch into pieces smaller than that
makes sense.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html