On Mon, Oct 17, 2011 at 9:20 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > > What are these changes for, except perhaps to make the patch larger than > necesssary to make it harder to review? > > It would leave an unnecessary SP like 'class="diff "' when all the arms of > if/elsif cascade fall off and $diff_class is left empty. It isn't a major > issue (I suspect that such a case might even be an error), and I even > think the code after the above patch would be easier to read and more > sensible, but shouldn't that kind of "style fix" be in a separate clean-up > patch that does not introduce any new feature? > Sorry. I will separate my patch into two or three commits. Probably like: - format_diff_line returns a class with an line. - remove trailing space from the class. - add side-by-side feature and CSS. - add form. Thank you for your correction! -- Kato Kazuyoshi -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html