Thomas Rast <trast@xxxxxxxxxxxxxxx> writes: > Junio C Hamano wrote: >> Michael Haggerty <mhagger@xxxxxxxxxxxx> writes: >> >> > Previously, get_sha1_hex() would read one character past the end of a >> > null-terminated string whose strlen was an even number less than 40. >> > Although the function correctly returned -1 in these cases, the extra >> > memory access might have been to uninitialized (or even, conceivably, >> > unallocated) memory. >> > >> > Add a check to avoid reading past the end of a string. >> >> Makes sense; thanks. > > Has this fixed patch ever made it to pu? I'm still seeing the same > breakage in the automated valgrind runs. I do not think so. I was under the impression that Michael wanted to include this in the early part of a re-roll of check-ref-format series. I'll do the rebase myself. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html