Junio C Hamano wrote: > Michael Haggerty <mhagger@xxxxxxxxxxxx> writes: > > > Previously, get_sha1_hex() would read one character past the end of a > > null-terminated string whose strlen was an even number less than 40. > > Although the function correctly returned -1 in these cases, the extra > > memory access might have been to uninitialized (or even, conceivably, > > unallocated) memory. > > > > Add a check to avoid reading past the end of a string. > > Makes sense; thanks. Has this fixed patch ever made it to pu? I'm still seeing the same breakage in the automated valgrind runs. -- Thomas Rast trast@{inf,student}.ethz.ch -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html