On Sun, Sep 25, 2011 at 1:06 PM, Pang Yan Han <pangyanhan@xxxxxxxxx> wrote: > Signed-off-by: Pang Yan Han <pangyanhan@xxxxxxxxx> > --- > url.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/url.c b/url.c > index 3e06fd3..d2e17e6 100644 > --- a/url.c > +++ b/url.c > @@ -22,7 +22,6 @@ int is_url(const char *url) > > if (!url) > return 0; > - url2 = url; > first_slash = strchr(url, '/'); > > /* Input with no slash at all or slash first can't be URL. */ Looks correct. Perhaps you could mention in the patch message that There are no operations on url2 until another assignment to it later at line 41. -- Cheers, Ray Chuan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html